代码优化-ifelse语句-蒲公英云

代码优化-ifelse语句

清疚 2024-04-18 09:32 208阅读 0赞

对于if-else的代码，可以用以下方式增加可读性

public void changePidByPid(String seqNo) {
        String seqNoBak = scaiAgainPushMapper.selectScaiZbankRuleDecisionJnlBySeqNoBak(seqNo+"_bak");
        //seqNoBak为空，说明该进件是第一次手动重发，那么就将之前的seqNo改为seqNo_bak
        if(seqNoBak == null){
            scaiAgainPushMapper.changeScaiZbankRuleDecisionJnl(seqNo);
            scaiAgainPushMapper.changeScaiZbankRuledecisionReq(seqNo);
            scaiAgainPushMapper.changeScaiZbankRuledecisionResp(seqNo);
            scaiAgainPushMapper.changeScaiRideReq(seqNo);
            scaiAgainPushMapper.changeScaiRideResp(seqNo);
            scaiAgainPushMapper.changeScaiReqCreditApply(seqNo);
        }else{
            //seqNoBak不为空，说明该进件第一次手动重发又失败了，seqNo_bak已经存在了，那么就将失败后的seqNo相关删了
            scaiAgainPushMapper.deleteScaiZbankRuleDecisionJnl(seqNo);
            scaiAgainPushMapper.deleteScaiZbankRuledecisionReq(seqNo);
            scaiAgainPushMapper.deleteScaiZbankRuledecisionResp(seqNo);
            scaiAgainPushMapper.deleteScaiRideReq(seqNo);
            scaiAgainPushMapper.deleteScaiRideResp(seqNo);
            scaiAgainPushMapper.deleteScaiReqCreditApply(seqNo);
        }
    }

优化写法

public void changePidByPid(String seqNo) {
        String seqNoBak = scaiAgainPushMapper.selectScaiZbankRuleDecisionJnlBySeqNoBak(seqNo+"_bak");
        //seqNoBak为空，说明该进件是第一次手动重发，那么就将之前的seqNo改为seqNo_bak
        if(seqNoBak == null){
            scaiAgainPushMapper.changeScaiZbankRuleDecisionJnl(seqNo);
            scaiAgainPushMapper.changeScaiZbankRuledecisionReq(seqNo);
            scaiAgainPushMapper.changeScaiZbankRuledecisionResp(seqNo);
            scaiAgainPushMapper.changeScaiRideReq(seqNo);
            scaiAgainPushMapper.changeScaiRideResp(seqNo);
            scaiAgainPushMapper.changeScaiReqCreditApply(seqNo);
            return;
        }
        //seqNoBak不为空，说明该进件第一次手动重发又失败了，seqNo_bak已经存在了，那么就将失败后的seqNo相关删了
        scaiAgainPushMapper.deleteScaiZbankRuleDecisionJnl(seqNo);
        scaiAgainPushMapper.deleteScaiZbankRuledecisionReq(seqNo);
        scaiAgainPushMapper.deleteScaiZbankRuledecisionResp(seqNo);
        scaiAgainPushMapper.deleteScaiRideReq(seqNo);
        scaiAgainPushMapper.deleteScaiRideResp(seqNo);
        scaiAgainPushMapper.deleteScaiReqCreditApply(seqNo);
    }